Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yet another improvement to development process #73

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Yet another improvement to development process #73

merged 3 commits into from
Jun 19, 2024

Conversation

kispaljr
Copy link
Collaborator

@kispaljr kispaljr commented Jun 18, 2024 •
edited
Loading

This PR contains:

  • FIX for a prow issue introduced by Improvements in the development process #72
  • new make target called destroy that deletes the current porch deployment
  • better strategy to keep (kpt) state between porch deployments (instead of trying to preserve the resourcegroup.yaml file)
  • use server-side apply for porch deployments
  • do not build container images of locally running processes
  • fix function-runner IP address in .vscode/launch.json

WARNING: unfortunately the new porch deploy method conflicts with the old one, so you have to delete and recreate your kind cluster after this change is merged into your local setup.

@kispaljr kispaljr marked this pull request as draft June 18, 2024 14:54
@kispaljr kispaljr requested review from liamfallon, efiacor and pauldennehy and removed request for s3wong and johnbelamaric June 18, 2024 14:54
@kispaljr kispaljr marked this pull request as ready for review June 18, 2024 16:48
@nephio-prow nephio-prow bot requested a review from tliron June 18, 2024 16:48
@kispaljr kispaljr marked this pull request as draft June 19, 2024 11:16
@kispaljr kispaljr marked this pull request as ready for review June 19, 2024 11:39
@nephio-prow nephio-prow bot requested a review from henderiw June 19, 2024 11:39
@kispaljr
Copy link
Collaborator Author

/retest

@kispaljr kispaljr changed the title Yet another (really minor) improvement to development process Yet another improvement to development process Jun 19, 2024
@pauldennehy
Copy link
Contributor

/approve

liamfallon
liamfallon reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jun 19, 2024
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kispaljr, liamfallon, pauldennehy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 19, 2024
@nephio-prow nephio-prow bot merged commit 68319d9 into nephio-project:main Jun 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamfallon liamfallon liamfallon left review comments

@efiacor efiacor Awaiting requested review from efiacor

@pauldennehy pauldennehy Awaiting requested review from pauldennehy

@tliron tliron Awaiting requested review from tliron

@henderiw henderiw Awaiting requested review from henderiw

Assignees

@liamfallon liamfallon

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kispaljr @pauldennehy @liamfallon